Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added command for reading value from memory #346

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
103 changes: 103 additions & 0 deletions handlers.c
Original file line number Diff line number Diff line change
Expand Up @@ -1615,6 +1615,109 @@ bool handler__write(globals_t * vars, char **argv, unsigned argc)
return ret;
}


/* read value_type address */
bool handler__read(globals_t * vars, char **argv, unsigned argc)
{
FILE* pager = get_pager(stdout);

int data_width = 0;
const char *fmt = NULL;
void* buf = NULL;
void *addr;
bool ret;
int datatype;
char *endptr;

if (argc != 3)
{
show_error("bad arguments, see `help read`.\n");
ret = false;
goto retl;
}

scan_data_type_t st = parse_scan_data_type(argv[1]);

/* try int first */
if (st == INTEGER8)
{
data_width = 1;
datatype = 0;
fmt = "%"PRId8;
}
else if (st == INTEGER16)
{
data_width = 2;
datatype = 0;
fmt = "%"PRId16;
}
else if (st == INTEGER32)
{
data_width = 4;
datatype = 0;
fmt = "%"PRId32;
}
else if (st == INTEGER64)
{
data_width = 8;
datatype = 0;
fmt = "%"PRId64;
}
else if (st == FLOAT32)
{
data_width = 4;
datatype = 0;
fmt = "%f";
}
else if (st == FLOAT64)
{
data_width = 8;
datatype = 0;
fmt = "%lf";
}
else
{
show_error("bad data_type, see `help r`.\n");
ret = false;
goto retl;
}


errno = 0;
addr = (void *)(strtoll(argv[2], &endptr, 16));
if ((errno != 0) || (*endptr != '\0'))
{
show_error("bad address, see `help read`.\n");
ret = false;
goto retl;
}
st = parse_scan_data_type(argv[1]);

(void) datatype;

buf = malloc(data_width);

if (!sm_read_array(vars->target, addr, buf, data_width))
{
show_error("read memory failed.\n");
ret = false;
goto retl;
}
if (st == INTEGER8) fprintf(pager, fmt, *(int8_t*)buf);
if (st == INTEGER16) fprintf(pager, fmt, *(int16_t*)buf);
if (st == INTEGER32) fprintf(pager, fmt, *(int32_t*)buf);
if (st == INTEGER64) fprintf(pager, fmt, *(int64_t*)buf);
if (st == FLOAT32) fprintf(pager, fmt, *(float*)buf);
if (st == FLOAT64) fprintf(pager, fmt, *(double*)buf);

retl:

close_pager(pager);
if(buf)
free(buf);
return ret;
}

bool handler__option(globals_t * vars, char **argv, unsigned argc)
{
/* this might need to change */
Expand Down
15 changes: 15 additions & 0 deletions handlers.h
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,21 @@ bool handler__dump(globals_t *vars, char **argv, unsigned argc);

bool handler__write(globals_t *vars, char **argv, unsigned argc);

#define READ_COMPLETE VALUE_TYPES
#define READ_SHRTDOC "read value of a specific memory location"
#define READ_LONGDOC "usage: write <value_type> <address>\n" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

write is a copy and paste mistake here.

"\n" \
"Read <value_type> from <address>\n" \
"<value_type> should be one of:\n" \
"\tint{8|16|32|64} (or i{8|16|32|64} for short)\n" \
"\tfloat{32|64} (or f{32|64} for short)\n" \
"\n" \
"Example:\n" \
"\tread i16 60103e\n" \
"\tread float32 60103e\n"

bool handler__read(globals_t *vars, char **argv, unsigned argc);

#define OPTION_COMPLETE "scan_data_type{number,int,float," VALUE_TYPES \
"},region_scan_level{1,2,3},dump_with_ascii{0,1},endianness{0,1,2}"
#define OPTION_SHRTDOC "set runtime options of scanmem, see `help option`"
Expand Down
2 changes: 2 additions & 0 deletions scanmem.c
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,8 @@ bool sm_init(void)
SHOW_LONGDOC, SHOW_COMPLETE);
sm_registercommand("dump", handler__dump, vars->commands, DUMP_SHRTDOC,
DUMP_LONGDOC, NULL);
sm_registercommand("read", handler__read, vars->commands, READ_SHRTDOC,
READ_LONGDOC, READ_COMPLETE);
sm_registercommand("write", handler__write, vars->commands, WRITE_SHRTDOC,
WRITE_LONGDOC, WRITE_COMPLETE);
sm_registercommand("option", handler__option, vars->commands, OPTION_SHRTDOC,
Expand Down