Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ensure_log_order config #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shivaken
Copy link

This PR adds an option 'ensure_log_order' to enable/disable a block of code to 'ensure timestamp is at least 1 nanosecond greater than the last one'.

This change might be needed in cases like us, sending log to Scalyr through a fluentd setup for routing purpose instead of sending it from server instances directly.

@imron
Copy link
Contributor

imron commented Oct 29, 2019

Thanks for submitting this.

This code is there because until recently, the way Scalyr stored logs on the server required each log coming from a single Scalyr session (represented in the plugin by @session) to have an timestamp larger than any previous logs in that session (regardless of which log file/source it came from). Log lines failing to meet that condition were discarded.

This restriction was recently lifted, but we're still testing it out to confirm that everything works.

Once fully verified, this entire section of code will be removed, so for now, we'll likely hold off on merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants