Reduce client errors when servers overloaded #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Scalyr's servers are overloaded, they return a combination of "too busy" HTTP responses and internal errors, both of which result in ERROR-level log messages in the agent log. This commit adds explicit checking for the specific error message that accompanies internal errors when the servers are too busy, and downgrades the log messages to warnings since the agent retries automatically and no human intervention is required.
|
Hi sgrimm-sg, thanks for submitting this pull request, and sorry it slipped through the cracks and didn't get a response for so long. I'll be taking a look at this some time over the next few days and will update you then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Scalyr's servers are overloaded, they return a combination of "too
busy" HTTP responses and internal errors, both of which result in
ERROR-level log messages in the agent log.
This commit adds explicit checking for the specific error message that
accompanies internal errors when the servers are too busy, and
downgrades the log messages to warnings since the agent retries
automatically and no human intervention is required.