Improvement/artesca 10858 empty state #735

JeanMarcMilletScality · 2024-03-08T10:24:35Z

No description provided.

bert-e · 2024-03-08T10:24:38Z

Hello jeanmarcmilletscality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2024-03-08T10:24:45Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2024-03-18T10:56:49Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2024-03-20T14:25:52Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

codecov-commenter · 2024-03-20T14:31:34Z

Codecov Report

Attention: Patch coverage is 55.76923% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 59.31%. Comparing base (958f489) to head (a541acc).
Report is 8 commits behind head on development/2.2.

Files	Patch %	Lines
src/react/databrowser/buckets/BucketList.tsx	0.00%	8 Missing ⚠️
src/react/account/AccountUserAccessKeys.tsx	0.00%	3 Missing ⚠️
src/react/account/Accounts.tsx	57.14%	3 Missing ⚠️
src/react/locations/LocationsList.tsx	0.00%	2 Missing ⚠️
src/react/Routes.tsx	0.00%	1 Missing ⚠️
src/react/account/AccountList.tsx	66.66%	1 Missing ⚠️
src/react/account/AccountLocations.tsx	0.00%	1 Missing ⚠️
src/react/databrowser/DataBrowser.tsx	0.00%	1 Missing ⚠️
src/react/databrowser/buckets/details/Workflow.tsx	0.00%	1 Missing ⚠️
src/react/databrowser/objects/ObjectDelete.tsx	50.00%	1 Missing ⚠️
... and 1 more

Additional details and impacted files

@@                 Coverage Diff                 @@
##           development/2.2     #735      +/-   ##
===================================================
+ Coverage            59.20%   59.31%   +0.10%     
===================================================
  Files                  239      239              
  Lines                11309    11256      -53     
  Branches              3260     3223      -37     
===================================================
- Hits                  6696     6677      -19     
+ Misses                4592     4559      -33     
+ Partials                21       20       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bert-e · 2024-03-25T10:47:53Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

…stom or deprecated elements for up to date Core-UI elements

…flow and table autosizer continuously triggering each other

bert-e · 2024-06-04T15:21:07Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2024-06-04T15:29:35Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2024-06-06T09:12:46Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

JBWatenbergScality · 2024-06-06T09:35:38Z

src/react/databrowser/DataBrowser.tsx

- </EmptyStateContainer>
+ <EmptyState
+ icon="Bucket"
+ link="create-account"


maybe missing the leading "/"

JBWatenbergScality · 2024-06-06T09:39:21Z

src/react/workflow/Workflows.tsx

- </EmptyStateContainer>
+ <EmptyState
+ icon="Bucket"
+ link={`accounts/${accountName}/create-bucket`}


Missing a leading slash

bert-e · 2024-06-06T12:05:05Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2024-06-06T14:51:03Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

JBWatenbergScality

LGTM !

JeanMarcMilletScality · 2024-06-07T13:24:19Z

/approve

bert-e · 2024-06-07T13:24:29Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/2.2

The following branches have NOT changed:

development/1.4
development/1.5
development/1.6
development/2.0
development/2.1

Please check the status of the associated issue ARTESCA-10858.

Goodbye jeanmarcmilletscality.

The following options are set: approve

JeanMarcMilletScality force-pushed the improvement/ARTESCA-10858-empty-state branch from a541acc to 4bfd4c8 Compare March 25, 2024 10:47

JeanMarcMilletScality added 22 commits June 4, 2024 16:33

update table

a04be86

change warning for core-ui empty state

8844d16

update table

06f74ea

update empty state, use empty state from core-ui

f2c4425

fix Empty state of workflow

21e06c0

fix ts error, different names were used for the same value

7476703

update emptyState

b18f9a2

use Icon with wrapper instead of custom icon

41385c5

update table and emptystate with new Core-Ui versions, change some cu…

b59ce75

…stom or deprecated elements for up to date Core-UI elements

change style, remove some padding

257e4bf

remove the errorTable label prop, as it is not use anymore

87f8afe

update tests affected by the update of table or emptystate

ba60a1f

update and cleaning of ui elements

643f498

update packages

ed0448f

change flex for width in table to avoid table going over right panel

f88c623

allow editor to switch theme with ui

208a2c0

add overflow-x property to avoid flashing table, probably due to over…

82bbc6f

…flow and table autosizer continuously triggering each other

add padding to give space for caret in table

16bdd4c

change table proportion for better display

6539653

improve table displays, resolve issues on smaller screen

fcbe27f

center no account warning

547bb2f

fix typo in test

58095cc

JeanMarcMilletScality force-pushed the improvement/ARTESCA-10858-empty-state branch from 4bfd4c8 to 58095cc Compare June 4, 2024 15:20

JeanMarcMilletScality added 2 commits June 6, 2024 11:11

update listedResource with singular and plural

aef3176

upadate packages

b017b52

JeanMarcMilletScality marked this pull request as ready for review June 6, 2024 09:24

JBWatenbergScality reviewed Jun 6, 2024

View reviewed changes

add missing leading slash

002705c

JeanMarcMilletScality added 2 commits June 6, 2024 16:50

update core ui

832b025

remove history after Core ui empty state update

501942e

JBWatenbergScality approved these changes Jun 7, 2024

View reviewed changes

bert-e merged commit 501942e into development/2.2 Jun 7, 2024
9 checks passed

bert-e deleted the improvement/ARTESCA-10858-empty-state branch June 7, 2024 13:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improvement/artesca 10858 empty state #735

Improvement/artesca 10858 empty state #735

JeanMarcMilletScality commented Mar 8, 2024

bert-e commented Mar 8, 2024

bert-e commented Mar 8, 2024

bert-e commented Mar 18, 2024

bert-e commented Mar 20, 2024

codecov-commenter commented Mar 20, 2024

bert-e commented Mar 25, 2024

bert-e commented Jun 4, 2024

bert-e commented Jun 4, 2024

bert-e commented Jun 6, 2024

JBWatenbergScality Jun 6, 2024

JBWatenbergScality Jun 6, 2024

bert-e commented Jun 6, 2024

bert-e commented Jun 6, 2024

JBWatenbergScality left a comment

JeanMarcMilletScality commented Jun 7, 2024

bert-e commented Jun 7, 2024

Improvement/artesca 10858 empty state #735

Improvement/artesca 10858 empty state #735

Conversation

JeanMarcMilletScality commented Mar 8, 2024

bert-e commented Mar 8, 2024

Hello jeanmarcmilletscality,

bert-e commented Mar 8, 2024

Waiting for approval

bert-e commented Mar 18, 2024

Waiting for approval

bert-e commented Mar 20, 2024

Waiting for approval

codecov-commenter commented Mar 20, 2024

Codecov Report

bert-e commented Mar 25, 2024

Waiting for approval

bert-e commented Jun 4, 2024

Waiting for approval

bert-e commented Jun 4, 2024

Waiting for approval

bert-e commented Jun 6, 2024

Waiting for approval

JBWatenbergScality Jun 6, 2024

Choose a reason for hiding this comment

JBWatenbergScality Jun 6, 2024

Choose a reason for hiding this comment

bert-e commented Jun 6, 2024

Waiting for approval

bert-e commented Jun 6, 2024

Waiting for approval

JBWatenbergScality left a comment

Choose a reason for hiding this comment

JeanMarcMilletScality commented Jun 7, 2024

bert-e commented Jun 7, 2024