Solve s3 proxy issues for object with keys containing urlencoded chars #554

JBWatenbergScality · 2023-03-24T10:55:06Z

No description provided.

bert-e · 2023-03-24T10:55:09Z

Hello jbwatenbergscality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

bert-e · 2023-03-24T10:55:17Z

Incorrect fix version

The Fix Version/s in issue ZKUI-317 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

1.6.11
2.0.0

Please check the Fix Version/s of ZKUI-317, or the target
branch of this pull request.

MonPote · 2023-03-27T13:00:39Z

test

bert-e · 2023-04-04T09:52:32Z

Incorrect fix version

The Fix Version/s in issue ZKUI-317 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

1.6.11
2.0.1

Please check the Fix Version/s of ZKUI-317, or the target
branch of this pull request.

codecov-commenter · 2023-04-04T10:02:57Z

Codecov Report

Merging #554 (60e6002) into development/2.1 (60e6002) will not change coverage.
The diff coverage is n/a.

❗ Current head 60e6002 differs from pull request most recent head 8df6ee9. Consider uploading reports for the commit 8df6ee9 to get more accurate results

@@               Coverage Diff                @@
##           development/2.1     #554   +/-   ##
================================================
  Coverage            53.84%   53.84%           
================================================
  Files                  218      218           
  Lines                10448    10448           
  Branches              2932     2932           
================================================
  Hits                  5626     5626           
  Misses                4804     4804           
  Partials                18       18

bert-e · 2023-04-11T20:18:31Z

Incorrect fix version

The Fix Version/s in issue ZKUI-317 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

1.6.12
2.0.1

Please check the Fix Version/s of ZKUI-317, or the target
branch of this pull request.

bert-e · 2023-04-13T12:45:42Z

Incorrect fix version

The Fix Version/s in issue ZKUI-317 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

1.6.12
2.0.2

Please check the Fix Version/s of ZKUI-317, or the target
branch of this pull request.

JBWatenbergScality · 2023-04-13T14:29:51Z

/status

bert-e · 2023-04-13T14:29:55Z

Status

Status report is not available.

bert-e · 2023-04-13T14:30:04Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/ZKUI-317-test-signature-approach into
development/1.6
w/2.0/bugfix/ZKUI-317-test-signature-approach will be merged into development/2.0

The following branches will NOT be impacted:

development/1.4
development/1.5

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

bert-e · 2023-04-13T14:30:07Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

ChengYanJin · 2023-04-13T14:45:10Z

THIS IS AMAZING !

bert-e · 2023-06-09T14:10:56Z

Branches have diverged

This pull request's source branch bugfix/ZKUI-317-test-signature-approach has diverged from
development/2.1 by more than 100 commits.

To avoid any integration risks, please re-synchronize them using one of the
following solutions:

Merge origin/development/2.1 into bugfix/ZKUI-317-test-signature-approach
Rebase bugfix/ZKUI-317-test-signature-approach onto origin/development/2.1

Note: If you choose to rebase, you may have to ask me to rebuild
integration branches using the reset command.

…ncoded chars

bert-e · 2023-06-12T10:07:12Z

Incorrect fix version

The Fix Version/s in issue ZKUI-317 contains:

1.6.12
2.0.2

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

2.1.0

Please check the Fix Version/s of ZKUI-317, or the target
branch of this pull request.

JBWatenbergScality · 2023-06-12T10:08:02Z

/status

bert-e · 2023-06-12T10:08:06Z

Status

Status report is not available.

bert-e · 2023-06-12T10:08:15Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

This commit is the integration of #554

ZKUI-371 - update webpack configs ZKUI-371 - update webpack's deps ZKUI-371 - fix build fix svg warning ZKUI-371 - fix security check fix dev webpack environnement fix monaco issue replace push from connected-react-router for history in react component remove navbar fix user creation fix grafana url fix all tests update core-ui fix rebase Remove legacy cypress tests fix linter errors make prod ready change public path fix sts endpoint fix debug fix change client endpoint Solve s3 proxy issues for object with keys containing urlencoded chars This commit is the integration of #554 fix s3client add basePath in s3client Fix security workflow fix test Add go template fix ci Remove index.html remove default to index.html fix basepath for zenko client

ChengYanJin approved these changes Apr 13, 2023

View reviewed changes

JBWatenbergScality changed the title ~~Attempt to solve s3 proxy issues for object with keys containing urlencoded chars~~ Solve s3 proxy issues for object with keys containing urlencoded chars Apr 13, 2023

MonPote approved these changes Apr 13, 2023

View reviewed changes

JBWatenbergScality changed the base branch from development/1.6 to development/2.1 June 9, 2023 14:10

JBWatenbergScality added 7 commits June 12, 2023 12:06

Attempt to solve s3 proxy issues for object with keys containing urle…

6a11410

…ncoded chars

Try using kube internal domains to sign the requests

535fe8d

fix additional dot to fixup

7d5ac6a

Get internal FQDN from configuration in order to configure AWS signer

70d74ad

add upload cypress to ci to ease debugging

db28bfc

test: Fix missing fields in test config

6edc1bb

Remove proxy-pass-header in nginx configuration

8df6ee9

JBWatenbergScality force-pushed the bugfix/ZKUI-317-test-signature-approach branch from d1e7b2c to 8df6ee9 Compare June 12, 2023 10:07

MonPote added a commit that referenced this pull request Aug 8, 2023

Solve s3 proxy issues for object with keys containing urlencoded chars

36b5677

This commit is the integration of #554

JBWatenbergScality pushed a commit that referenced this pull request Sep 11, 2023

Solve s3 proxy issues for object with keys containing urlencoded chars

3e79635

This commit is the integration of #554

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Solve s3 proxy issues for object with keys containing urlencoded chars #554

Solve s3 proxy issues for object with keys containing urlencoded chars #554

JBWatenbergScality commented Mar 24, 2023

bert-e commented Mar 24, 2023

bert-e commented Mar 24, 2023

MonPote commented Mar 27, 2023

bert-e commented Apr 4, 2023

codecov-commenter commented Apr 4, 2023 •

edited

bert-e commented Apr 11, 2023

bert-e commented Apr 13, 2023

JBWatenbergScality commented Apr 13, 2023

bert-e commented Apr 13, 2023

bert-e commented Apr 13, 2023

bert-e commented Apr 13, 2023

ChengYanJin commented Apr 13, 2023

bert-e commented Jun 9, 2023

bert-e commented Jun 12, 2023

JBWatenbergScality commented Jun 12, 2023

bert-e commented Jun 12, 2023

bert-e commented Jun 12, 2023

Solve s3 proxy issues for object with keys containing urlencoded chars #554

Are you sure you want to change the base?

Solve s3 proxy issues for object with keys containing urlencoded chars #554

Conversation

JBWatenbergScality commented Mar 24, 2023

bert-e commented Mar 24, 2023

Hello jbwatenbergscality,

bert-e commented Mar 24, 2023

Incorrect fix version

MonPote commented Mar 27, 2023

bert-e commented Apr 4, 2023

Incorrect fix version

codecov-commenter commented Apr 4, 2023 • edited

Codecov Report

bert-e commented Apr 11, 2023

Incorrect fix version

bert-e commented Apr 13, 2023

Incorrect fix version

JBWatenbergScality commented Apr 13, 2023

bert-e commented Apr 13, 2023

Status

bert-e commented Apr 13, 2023

Integration data created

bert-e commented Apr 13, 2023

Waiting for approval

ChengYanJin commented Apr 13, 2023

bert-e commented Jun 9, 2023

Branches have diverged

bert-e commented Jun 12, 2023

Incorrect fix version

JBWatenbergScality commented Jun 12, 2023

bert-e commented Jun 12, 2023

Status

bert-e commented Jun 12, 2023

Waiting for approval

codecov-commenter commented Apr 4, 2023 •

edited