BB-295 - bootstrap ts compilation #2337
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello jbertran,My role is to assist you with the merge of this Status report is not available. |
jbertran
force-pushed
the
improvement/BB-295-bootstrap-ts-compilation
branch
from
3f5f8fd
to
5c27835
Compare
|
/approve |
|
/wait |
Kerkesni
force-pushed
the
improvement/BB-295-bootstrap-ts-compilation
branch
6 times, most recently
from
7d247d7
to
7df7f4d
Compare
Kerkesni
force-pushed
the
improvement/BB-295-bootstrap-ts-compilation
branch
from
45cd2d7
to
ff1f5dc
Compare
Kerkesni
force-pushed
the
improvement/BB-295-bootstrap-ts-compilation
branch
from
ff1f5dc
to
4b4967b
Compare
Kerkesni
force-pushed
the
improvement/BB-295-bootstrap-ts-compilation
branch
from
4b4967b
to
9f2483d
Compare
tmacro
requested changes
Feb 13, 2023
Kerkesni
force-pushed
the
improvement/BB-295-bootstrap-ts-compilation
branch
from
1e3adae
to
ef611a1
Compare
| httpServer.close(); | ||
| async.parallel([ | ||
| async.series([ |
There was a problem hiding this comment.
This doesn't seem to be strictly related to typescript/jest, is there a reason for this change?
| @@ -42,7 +57,7 @@ describe('NotificationConfigManager ::', () => { | |||
| manager = new NotificationConfigManager(params); | |||
| const getCollectionStub = sinon.stub().returns({ | |||
| // mock change stream | |||
| watch: () => new events.EventEmitter(), | |||
| watch: () => new MockChangeStream(), | |||
There was a problem hiding this comment.
This doesn't seem to be strictly related to typescript/jest, is there a reason for this change?
Comment on lines
-125
to
+126
| consumer.unsubscribe(); | ||
| consumer.pause(); |
There was a problem hiding this comment.
Why this change (and the subscribe/resume one)? Was the test wrong before?
tmacro
approved these changes
Mar 24, 2023
…nto tmp/octopus/q/8.7
…p/octopus/w/8.7/bugfix/BB-455-clean-shutdown-backbeat-consumer
… and 'q/2458/8.6/bugfix/BB-455-clean-shutdown-backbeat-consumer' into tmp/octopus/q/8.7
…o tmp/octopus/w/8.7/feature/BB-452-delete-notification-versionid
- add eslint-plugin-jest for jest globals - upgrade esling - fix remaining lint issues
- provide minimal package.json - move all files to tests/utils/syntheticbucketd
Issue: BB-295
francoisferrand
force-pushed
the
improvement/BB-295-bootstrap-ts-compilation
branch
2 times, most recently
from
7083476
to
54273c6
Compare
francoisferrand
force-pushed
the
improvement/BB-295-bootstrap-ts-compilation
branch
from
980f7e4
to
102140b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outcome so far:
Remaining work is simply ensuring all other test suites pass (bonus: make them separate parallel steps in the build process, such that the work doesn’t need to be sequential).
Zenko Build: https://github.com/scality/Zenko/actions/runs/3822509132