Skip to content

feat(k8s): enable passing a security group ID at pool creation #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025
Merged

feat(k8s): enable passing a security group ID at pool creation #1014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions scaleway-async/scaleway_async/k8s/v1/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1044,6 +1044,7 @@ async def create_pool(
zone: Optional[ScwZone] = None,
root_volume_type: Optional[PoolVolumeType] = None,
root_volume_size: Optional[int] = None,
security_group_id: Optional[str] = None,
) -> Pool:
"""
Create a new Pool in a Cluster.
Expand All @@ -1069,6 +1070,7 @@ async def create_pool(
* `sbs-15k` is a faster remote block storage which means your system is stored on a centralized and resilient cluster with 15k IOPS limits
* `b_ssd` is the legacy remote block storage which means your system is stored on a centralized and resilient cluster. Consider using `sbs-5k` or `sbs-15k` instead.
:param root_volume_size: System volume disk size.
:param security_group_id: Security group ID in which all the nodes of the pool will be created. If unset, the pool will use default Kapsule security group in current zone.
:return: :class:`Pool <Pool>`

Usage:
Expand Down Expand Up @@ -1112,6 +1114,7 @@ async def create_pool(
zone=zone,
root_volume_type=root_volume_type,
root_volume_size=root_volume_size,
security_group_id=security_group_id,
),
self.client,
),
Expand Down
10 changes: 10 additions & 0 deletions scaleway-async/scaleway_async/k8s/v1/marshalling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,10 @@ def unmarshal_Pool(data: Any) -> Pool:
if field is not None:
args["public_ip_disabled"] = field

field = data.get("security_group_id", None)
if field is not None:
args["security_group_id"] = field

field = data.get("region", None)
if field is not None:
args["region"] = field
Expand Down Expand Up @@ -1282,6 +1286,9 @@ def marshal_CreateClusterRequestPoolConfig(
if request.root_volume_size is not None:
output["root_volume_size"] = request.root_volume_size

if request.security_group_id is not None:
output["security_group_id"] = request.security_group_id

return output


Expand Down Expand Up @@ -1434,6 +1441,9 @@ def marshal_CreatePoolRequest(
if request.root_volume_size is not None:
output["root_volume_size"] = request.root_volume_size

if request.security_group_id is not None:
output["security_group_id"] = request.security_group_id

return output


Expand Down
15 changes: 15 additions & 0 deletions scaleway-async/scaleway_async/k8s/v1/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,11 @@ class Pool:
Defines if the public IP should be removed from Nodes. To use this feature, your Cluster must have an attached Private Network set up with a Public Gateway.
"""

security_group_id: str
"""
Security group ID in which all the nodes of the pool will be created. If unset, the pool will use default Kapsule security group in current zone.
"""

region: ScwRegion
"""
Cluster region of the pool.
Expand Down Expand Up @@ -677,6 +682,11 @@ class CreateClusterRequestPoolConfig:
System volume disk size.
"""

security_group_id: Optional[str]
"""
Security group ID in which all the nodes of the pool will be created. If unset, the pool will use default Kapsule security group in current zone.
"""


@dataclass
class CreatePoolRequestUpgradePolicy:
Expand Down Expand Up @@ -1342,6 +1352,11 @@ class CreatePoolRequest:
System volume disk size.
"""

security_group_id: Optional[str]
"""
Security group ID in which all the nodes of the pool will be created. If unset, the pool will use default Kapsule security group in current zone.
"""


@dataclass
class DeleteACLRuleRequest:
Expand Down
3 changes: 3 additions & 0 deletions scaleway/scaleway/k8s/v1/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1044,6 +1044,7 @@ def create_pool(
zone: Optional[ScwZone] = None,
root_volume_type: Optional[PoolVolumeType] = None,
root_volume_size: Optional[int] = None,
security_group_id: Optional[str] = None,
) -> Pool:
"""
Create a new Pool in a Cluster.
Expand All @@ -1069,6 +1070,7 @@ def create_pool(
* `sbs-15k` is a faster remote block storage which means your system is stored on a centralized and resilient cluster with 15k IOPS limits
* `b_ssd` is the legacy remote block storage which means your system is stored on a centralized and resilient cluster. Consider using `sbs-5k` or `sbs-15k` instead.
:param root_volume_size: System volume disk size.
:param security_group_id: Security group ID in which all the nodes of the pool will be created. If unset, the pool will use default Kapsule security group in current zone.
:return: :class:`Pool <Pool>`

Usage:
Expand Down Expand Up @@ -1112,6 +1114,7 @@ def create_pool(
zone=zone,
root_volume_type=root_volume_type,
root_volume_size=root_volume_size,
security_group_id=security_group_id,
),
self.client,
),
Expand Down
10 changes: 10 additions & 0 deletions scaleway/scaleway/k8s/v1/marshalling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,10 @@ def unmarshal_Pool(data: Any) -> Pool:
if field is not None:
args["public_ip_disabled"] = field

field = data.get("security_group_id", None)
if field is not None:
args["security_group_id"] = field

field = data.get("region", None)
if field is not None:
args["region"] = field
Expand Down Expand Up @@ -1282,6 +1286,9 @@ def marshal_CreateClusterRequestPoolConfig(
if request.root_volume_size is not None:
output["root_volume_size"] = request.root_volume_size

if request.security_group_id is not None:
output["security_group_id"] = request.security_group_id

return output


Expand Down Expand Up @@ -1434,6 +1441,9 @@ def marshal_CreatePoolRequest(
if request.root_volume_size is not None:
output["root_volume_size"] = request.root_volume_size

if request.security_group_id is not None:
output["security_group_id"] = request.security_group_id

return output


Expand Down
15 changes: 15 additions & 0 deletions scaleway/scaleway/k8s/v1/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,11 @@ class Pool:
Defines if the public IP should be removed from Nodes. To use this feature, your Cluster must have an attached Private Network set up with a Public Gateway.
"""

security_group_id: str
"""
Security group ID in which all the nodes of the pool will be created. If unset, the pool will use default Kapsule security group in current zone.
"""

region: ScwRegion
"""
Cluster region of the pool.
Expand Down Expand Up @@ -677,6 +682,11 @@ class CreateClusterRequestPoolConfig:
System volume disk size.
"""

security_group_id: Optional[str]
"""
Security group ID in which all the nodes of the pool will be created. If unset, the pool will use default Kapsule security group in current zone.
"""


@dataclass
class CreatePoolRequestUpgradePolicy:
Expand Down Expand Up @@ -1342,6 +1352,11 @@ class CreatePoolRequest:
System volume disk size.
"""

security_group_id: Optional[str]
"""
Security group ID in which all the nodes of the pool will be created. If unset, the pool will use default Kapsule security group in current zone.
"""


@dataclass
class DeleteACLRuleRequest:
Expand Down