Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instance): wait for volumes after server deletion #4149

Merged

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Sep 27, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@Codelax Codelax added bug instance Instance issues, bugs and feature requests labels Sep 27, 2024
@Codelax Codelax force-pushed the fix/instance-server-delete-wait-for-volumes branch from 0568053 to b543c43 Compare October 24, 2024 09:06
@remyleone remyleone added the priority:high New features label Nov 12, 2024
@Codelax Codelax force-pushed the fix/instance-server-delete-wait-for-volumes branch from b543c43 to 7a504b2 Compare December 24, 2024 08:42
@github-actions github-actions bot added load-balancer Load-balancer issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests labels Dec 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 70.84%. Comparing base (5bf53e0) to head (853b96f).
Report is 409 commits behind head on master.

Files with missing lines Patch % Lines
...nal/namespaces/instance/v1/custom_server_delete.go 60.52% 12 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4149      +/-   ##
==========================================
- Coverage   75.45%   70.84%   -4.62%     
==========================================
  Files         202      296      +94     
  Lines       44323    65731   +21408     
==========================================
+ Hits        33444    46564   +13120     
- Misses       9653    17526    +7873     
- Partials     1226     1641     +415     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax marked this pull request as ready for review December 24, 2024 13:12
@Codelax Codelax requested a review from yfodil as a code owner December 24, 2024 13:12
@remyleone remyleone added this pull request to the merge queue Dec 26, 2024
Merged via the queue into scaleway:master with commit 59dcef3 Dec 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug instance Instance issues, bugs and feature requests load-balancer Load-balancer issues, bugs and feature requests priority:high New features vpc Virtual Private Cloud (VPC) issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants