-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new @scalar/api-reference-editor
package
#2091
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: dc749ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
c2dcc21
to
f39214e
Compare
#2180 Bundle Size — 3.97MiB (+0.04%).Bundle metrics
|
Current #2180 |
Baseline #2176 |
|
---|---|---|
Initial JS | 3.97MiB (+0.04% ) |
3.96MiB |
Initial CSS | 0B |
0B |
Cache Invalidation | 100% |
100% |
Chunks | 1 |
1 |
Assets | 1 |
1 |
Modules | 1232 (+0.08% ) |
1231 |
Duplicate Modules | 0 |
0 |
Duplicate Code | 0% |
0% |
Packages | 155 |
155 |
Duplicate Packages | 0 |
0 |
Bundle analysis report Branch geoff/add-reference-editor Project dashboard
@scalar/api-reference-editor
package
c1b9f61
to
4e6f03c
Compare
ba56a91
to
7837170
Compare
I’ve extracted the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i get an error for [vite-node] [ERR_LOAD_URL] ./nuxt-theme.css
on nuxt
also we should add some documentation to root README (even if just a link to the package readme) and remove our isEditable
prop
<slot></slot> | ||
</div> | ||
</template> | ||
<style> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets scope this :)
@@ -250,7 +250,19 @@ export type ReferenceLayoutSlot = | |||
| 'sidebar-start' | |||
| 'sidebar-end' | |||
|
|||
export type ReferenceLayoutSlots = { | |||
[x in ReferenceLayoutSlot]: (props: ReferenceSlotProps) => any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to specify any here? maybe a comment would help : )
import ClassicLayout from './ClassicLayout.vue' | ||
import ModernLayout from './ModernLayout.vue' | ||
|
||
// eslint-disable-next-line vue/no-unused-properties |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we just pick the props we use from this?
Adds an editor package to the repo to enable spec editing with internal or external state.
Derived from: #1490
Also includes a fix to remove the npx call of
@scalar/cli
during build tooling which is dangerous.