feat: new @scalar/api-reference-editor package
#2091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7c6b8bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
geoffgscott
force-pushed
the
geoff/add-reference-editor
branch
from
c2dcc21 to
f39214e
Compare
#2487 Bundle Size — 2.01MiB (+0.03%).Bundle metrics
|
| Current #2487 |
Baseline #2486 |
|
|---|---|---|
 Initial JS |
2.01MiB(+0.03%) |
2.01MiB |
 Initial CSS |
0B |
0B |
| Cache Invalidation |
100% |
100% |
| Chunks |
1 |
1 |
| Assets |
1 |
1 |
 Modules |
1238(+0.16%) |
1236 |
| Duplicate Modules |
0 |
0 |
| Duplicate Code |
0% |
0% |
| Packages |
158 |
158 |
| Duplicate Packages |
0 |
0 |
Bundle analysis report Branch geoff/add-reference-editor Project dashboard
hanspagel
changed the title
hanspagel
changed the title
@scalar/api-reference-editor package
hanspagel
force-pushed
the
geoff/add-reference-editor
branch
from
c1b9f61 to
4e6f03c
Compare
hanspagel
force-pushed
the
geoff/add-reference-editor
branch
from
ba56a91 to
7837170
Compare
|
I’ve extracted the |
marclave
requested changes
Jun 19, 2024
| <slot></slot> | ||
| </div> | ||
| </template> | ||
| <style> |
| @@ -250,7 +250,19 @@ export type ReferenceLayoutSlot = | |||
| | 'sidebar-start' | |||
| | 'sidebar-end' | |||
|
|
|||
| export type ReferenceLayoutSlots = { | |||
| [x in ReferenceLayoutSlot]: (props: ReferenceSlotProps) => any | |||
There was a problem hiding this comment.
do we need to specify any here? maybe a comment would help : )
There was a problem hiding this comment.
I'm not sure this is previous code that was moved.
| import ClassicLayout from './ClassicLayout.vue' | ||
| import ModernLayout from './ModernLayout.vue' | ||
|
|
||
| // eslint-disable-next-line vue/no-unused-properties |
There was a problem hiding this comment.
should we just pick the props we use from this?
There was a problem hiding this comment.
No we are passing props through.
fix: Test removing scalar cli from galaxy fix: Correct type errors chore: restore galaxy build command chore: reset version docs(changeset): init docs(changeset): chore: introduce the new @scalar/api-reference-editor chore: update lock file fix: scope css
geoffgscott
force-pushed
the
geoff/add-reference-editor
branch
from
07772e8 to
7c6b8bb
Compare
|
Preview deployed to https://87882de7-78db-4ff9-99e8-f87d0e6a8a4d--scalar-deploy-preview.netlify.app |
marclave
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an editor package to the repo to enable spec editing with internal or external state.
Derived from: #1490
Also includes a fix to remove the npx call of
@scalar/cliduring build tooling which is dangerous.