Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport "Support src filter in -WConf (Closes #17635) (#18783)" #20282

Open
wants to merge 1 commit into
base: release-3.3.4
Choose a base branch
from

Conversation

mkurz
Copy link
Contributor

@mkurz mkurz commented Apr 29, 2024

Backports

for next 3.3.4 release.

Besides import conflicts cherry-picking was smooth.

@mkurz
Copy link
Contributor Author

mkurz commented May 15, 2024

Any chance someone looks at this PR or assign the 3.3.4 milestone? Thanks!

@SethTisue
Copy link
Member

SethTisue commented May 27, 2024

Just chiming in to say that I think this would be highly beneficial to see merged for 3.3.4. Beneficial in general, but also specifically for our needs at Lightbend. (And of course @mkurz represents Play, obviously important users of Scala.)

There doesn't seem to be a 3.3.4 milestone I can assign. I'll take the liberty — which I try not to take too often! — of mentioning @Gedochao and @Kordyjan because I'd like to understand what the intended workflow is here. Like, is the target branch being release-3.3.4 sufficient for the PR to be noticed when 3.3.4 is put together? Or is there some label I could apply in a case like this? I thought about "backport:nominated" but it doesn't seem exactly apropos since this PR actually is a backport 😄

@SethTisue
Copy link
Member

SethTisue commented May 29, 2024

There was some discussion at core meeting today about LTS backports (cc @sjrd, who raised it). Some points:

  1. The team is aware there is a lack of public documentation about the intended workflow and they aim to improve it (but I'm not sure when, and @Kordyjan is currently less available than usual).
  2. The workflow involves mass backporting of many PRs at once, in chronological order to help keep the merge conflict situation from becoming unwieldy.
  3. Therefore, individual backport PRs like this one are (though obviously well intentioned, of course — thank you!) aren't as helpful as one might think and probably won't be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants