Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#106 pt. 1: Lighthouse #118

Merged
merged 1 commit into from
Oct 1, 2023
Merged

#106 pt. 1: Lighthouse #118

merged 1 commit into from
Oct 1, 2023

Conversation

dominikgeissler
Copy link
Contributor

Changelog

Changed

@dominikgeissler dominikgeissler added bug Something isn't working testing labels Oct 1, 2023
@dominikgeissler dominikgeissler requested a review from janosh October 1, 2023 18:21
@netlify
Copy link

netlify bot commented Oct 1, 2023

Deploy Preview for sbs-austria ready!

Name Link
🔨 Latest commit 8ea05d5
🔍 Latest deploy log https://app.netlify.com/sites/sbs-austria/deploys/6519b8be9966b50008748053
😎 Deploy Preview https://deploy-preview-118--sbs-austria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dominikgeissler
Copy link
Contributor Author

@janosh currently trying to fix the tests, i saw that the lighthouse tests were failing for ~ 6 months, i adjusted the minScore, I'm pretty sure this is not the "correct" way, do you know anything about this?

@janosh
Copy link
Member

janosh commented Oct 1, 2023

I'd say adjusting the minScore is fine for now. Eventually, someone might want to do careful performance optimization after which the minScore can be raised again.

@dominikgeissler dominikgeissler merged commit 303e4ff into main Oct 1, 2023
@dominikgeissler dominikgeissler deleted the fix/106 branch October 1, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants