Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Partial refactoring, fix: #913 #907 #880 #848 #784 #955

Open
wants to merge 4 commits into
base: php81
Choose a base branch
from

Conversation

Rushaway
Copy link
Contributor

@Rushaway Rushaway commented May 7, 2024

Description

  • Prevent players to avoid comms block issues
  • Fix players considered as not verified and cant be muted/gagged
  • Fix comms receive from web not applied immediatly
  • Create forward when player get unpunished
  • Adjust punish forward position
  • Optimisation of string read speed comparaison

Motivation and Context

#913 #907 #880 #848 #784

How Has This Been Tested?

In production on NiDE.GG since 5+ months

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

- Prevent players to avoid comms block issues
- Fix players considered as not verified and cant be muted/gagged
- Fix comms receive from web not applied immediatly
- Create forward when player get unpunished
- Adjust punish forward position
- Optimisation of string read speed comparaison
@Neoony
Copy link

Neoony commented May 17, 2024

getting error when compiling

@Neoony
Copy link

Neoony commented May 17, 2024

If I comment that out, it builds

However some error when I mute myself from server console
either with or without reason

but it seems it works and everything looks ok on web

@Rushaway
Copy link
Contributor Author

@Neoony You got this error because you commented the previous content without adjusting the Datapack, it's solved now.
Thanks for the review, appreciate it

@Neoony
Copy link

Neoony commented May 18, 2024

Yep, Now it builds fine and no more error ingame
Thx

@Rushaway
Copy link
Contributor Author

With this last commit (just pushed), it will prevent the only error I found with the timer handle who can be invalid.

No more issues left for me. Considering as stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants