Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional gametracker support #927

Open
wants to merge 13 commits into
base: php81
Choose a base branch
from

Conversation

connorrichlen
Copy link

@connorrichlen connorrichlen commented Sep 27, 2023

Description

-adds gametracker optional feature to display banner
-uses updater to add mysql setting

Motivation and Context

  • for server maintainers that want to display gametracker status

How Has This Been Tested?

-tested on an existing sb install

Screenshots (if appropriate):

https://i.gyazo.com/16377ab56df7714fbc75993439199747.png

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@Rushaway
Copy link
Contributor

Nice job. 😉
You missing to add the settings in the features as a checkbox.
Ex: https://github.com/sbpp/sourcebans-pp/blob/e3e8ff144b6dc1d5bb4d7c279eb5852a10d1faa8/web/themes/default/page_admin_settings_features.tpl#L47-#L54
And for the version bump. Idk if maintainer want to bump it.

@Rushaway
Copy link
Contributor

Maybe switch to 160px banner if server isn't empty ? What do you think?
Acutal render with the banner.
image

@connorrichlen
Copy link
Author

Haha thank you :D I seemed to have forgotten to actually add the support

@connorrichlen
Copy link
Author

Maybe switch to 160px banner if server isn't emptyimage

good call, check this out

@Rushaway
Copy link
Contributor

When you tick the box, settings are correctly saved ?
Based on e5bfd77

@connorrichlen
Copy link
Author

connorrichlen commented Sep 27, 2023

yes, but it requires a mysql entry, hence the new updater script

i did this a while ago on my own installation so i copied over what i remembered i did in the PR haha

@Rushaway
Copy link
Contributor

@crashzk You was able to make it run?

@crashzk
Copy link

crashzk commented Nov 20, 2023

@crashzk You was able to make it run?

No, I'm sorry... Since CS2 was released I closed the CSGO servers and focused on it, due to the limitations of the sourcebans it is currently "offline" so to speak.

@Rushaway
Copy link
Contributor

Rushaway commented Feb 6, 2024

I still can't make it run correctly. (tickbox aren't saved)

https://github.com/sbpp/sourcebans-pp/pull/927/files#diff-e3bb73ab9b4faf337bcf13a28231466a64044b4cae744db0e3581e6c432b3133R5
Value should not be null, you can use 536 as id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants