Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: ReadCell Position #916

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Fix: ReadCell Position #916

merged 1 commit into from
Aug 7, 2023

Conversation

Rushaway
Copy link
Contributor

@Rushaway Rushaway commented Aug 6, 2023

Description

  • Correct the read cell position
  • Add a debug to read cell position.

Motivation and Context

#893

How Has This Been Tested?

You can test it by uncomment L40 : #define DEBUG

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@Hackmastr Hackmastr merged commit e941246 into sbpp:php81 Aug 7, 2023
1 check passed
@Hackmastr Hackmastr mentioned this pull request Aug 24, 2023
Merged
@Rushaway Rushaway deleted the readcell-position branch August 28, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rushaway @Hackmastr