Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check if the Steamid format is valid by using
isValidID()
from SteamID.phpFor #900 I check if isset & is not empty (bcs they can be empty with sm_banip)
For #906 No need to check if set bcs all comms are based on steamid system (no ip supported)
Motivation and Context
Prevent bad format to break page view.
Give this
$data['steamid'] = 'STEAM_0:0:00000000';
when theisValid
return false.How Has This Been Tested?
For #900 I have a ban in db with
STEAM_ID_STOP_IGNORING_RETVALS
as SteamID inauthid
colume (also tested with a player name..)For #906 I have a comms in db with
STEAM_ID_STOP_IGNORING_RETVALS
as SteamID inauthid
columeScreenshots (if appropriate):
Types of changes
Checklist: