Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added discord webhook for ban protests #656

Open
wants to merge 2 commits into
base: v1.x
Choose a base branch
from

Conversation

B3none
Copy link

@B3none B3none commented Mar 29, 2020

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@crashzk
Copy link

crashzk commented Apr 3, 2020

@B3none enjoy this change, I hope it will be merged into the project, thank you.

I find it interesting to implement this feature also for Report Player. When a player makes a report on the Web Interface he would send it to Discord as well.

Suggestion for both implementation, it would be interesting if you had how to control which channel the messages would be sent to, but for that I believe you would need a plugin, something like the discord-forward plugin, would you be right?

@rumblefrog rumblefrog requested a review from Groruk April 5, 2020 03:57
@rumblefrog
Copy link
Member

No, you would not need a plugin for that.

Waiting for Groruk's view on this, not sure if it should be merged into core.

@TheGunter24
Copy link

@B3none could make that work with current release ?
ill get: Fatal error: Call to undefined function curl_init() in /var/www/html/bans/pages/page.protest.php on line 169

really looking forward to this addition, its annoying to manually look at protest ^^

@B3none
Copy link
Author

B3none commented May 6, 2020

@B3none could make that work with current release ?
ill get: Fatal error: Call to undefined function curl_init() in /var/www/html/bans/pages/page.protest.php on line 169

really looking forward to this addition, its annoying to manually look at protest ^^

Ensure you have php-curl extension downloaded and enabled

@SugarD-x
Copy link

Suggestion for both implementation, it would be interesting if you had how to control which channel the messages would be sent to, but for that I believe you would need a plugin, something like the discord-forward plugin, would you be right?

I may be wrong on this because I haven't tested this pull request myself, but I believe the webhook URL can be set per channel in Discord too, so that shouldn't be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants