More efficient way to check for negative time

sbpp · Mar 13, 2024 · 1b481ad · 1b481ad
1 parent 82113a8
commit 1b481ad
Showing 1 changed file with 6 additions and 9 deletions.
diff --git a/game/addons/sourcemod/scripting/sbpp_main.sp b/game/addons/sourcemod/scripting/sbpp_main.sp
@@ -545,12 +545,11 @@ public Action CommandBanIp(int client, int args)
  }
 
  char adminIp[24], adminAuth[64];
+ int minutes;
 
- int minutes = StringToInt(time);
-
- if (minutes < 0)
+ if (!StringToIntEx(time, minutes) || minutes < 0)
  {
- ReplyToCommand(client, "%sInvalid duration. Duration must be 0 or higher", Prefix);
+ ReplyToCommand(client, "%sUsage: sm_banip <#userid|name> <time> [reason]", Prefix);
  return Plugin_Handled;
  }
 
@@ -662,7 +661,7 @@ public Action CommandAddBan(int client, int args)
 
  GetCmdArgString(arg_string, sizeof(arg_string));
 
- int len, total_len;
+ int len, total_len, minutes;
 
  /* Get time */
  if ((len = BreakString(arg_string, time, sizeof(time))) == -1)
@@ -685,11 +684,9 @@ public Action CommandAddBan(int client, int args)
 
  char adminIp[24], adminAuth[64];
 
- int minutes = StringToInt(time);
-
- if (minutes < 0)
+ if (!StringToIntEx(time, minutes) || minutes < 0)
  {
- ReplyToCommand(client, "%sInvalid duration. Duration must be 0 or higher", Prefix);
+ ReplyToCommand(client, "%sUsage: sm_addban <time> <steamid> [reason]", Prefix);
  return Plugin_Handled;
  }