do not hardcode LD=ld in GNUmakefile #40
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cross compiling for an alternate libc implementation (e.g. musl for
static linking) a different linker required. It is currenly impossible
to pass LD=some-other-linker-ld in the environment or as part of a call
to make because the GNUmakefile hardcodes LD=ld. This commit fixes that
an also make it so that make-target-contrib.sh inhertis LD in the same
way that it inherits CC.
I'm to 100% sure that this works as expected. I've tried it in what should be a clean environment without issue, but am not entirely sure that LD will be set correctly be default.