Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not hardcode LD=ld in GNUmakefile #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tgbugs
Copy link

@tgbugs tgbugs commented Jan 26, 2021

When cross compiling for an alternate libc implementation (e.g. musl for
static linking) a different linker required. It is currenly impossible
to pass LD=some-other-linker-ld in the environment or as part of a call
to make because the GNUmakefile hardcodes LD=ld. This commit fixes that
an also make it so that make-target-contrib.sh inhertis LD in the same
way that it inherits CC.

I'm to 100% sure that this works as expected. I've tried it in what should be a clean environment without issue, but am not entirely sure that LD will be set correctly be default.

When cross compiling for an alternate libc implementation (e.g. musl for
static linking) a different linker required. It is currenly impossible
to pass LD=some-other-linker-ld in the environment or as part of a call
to make because the GNUmakefile hardcodes LD=ld. This commit fixes that
an also make it so that make-target-contrib.sh inhertis LD in the same
way that it inherits CC.
@catull
Copy link

catull commented Feb 28, 2021

I build sbcl twice or three times a year locally.

Currently using clang both as compiler and linker.
May want to try out LLVM's lld in future.

It'd be great to pass LD=MY_LINKER to make.sh.

Thanks for providing and maintaining SBCL!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants