Add wrapper around clock_gettime, needed for NetBSD #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this patch is needed for NetBSD because struct timespec evolved (long ago) and clock_gettime() is versioned.
Compilation of sbcl fails under at least NetBSD/aarch64 because (fortunately) make-source-info explicitly requests unsigned-byte and gets served a negative value due to clock-gettime reading the struct timespec fields with an inconsistent size wrt the syscall actually made.
There are two other incorrect calls of clock_gettime() in tests/deadlock.impure.lisp, and I don't know if there is a clean way à la syscall* to fix them. Otherwise #+netbsd "sb_clock_gettime" #-netbsd "clock_gettime" should do.
Regards,