Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Russian translation #325

Merged
merged 84 commits into from May 10, 2024
Merged

Add Russian translation #325

merged 84 commits into from May 10, 2024

Conversation

nifadyev
Copy link
Contributor

Translation is adaptive (not word-to-word) and it tries to save the original meaning.

As discussed with @satwikkansal, this translation (and possibly all existing ones) will be stored in folder inside original repository, not in fork. It will give more control because everything will be stored in 1 repository, and it eliminates possible deletion or making translation private.

Please feel free to review this PR. The PR will be periodically updated with new commits. 1 commit — 1 example

Resolves #297

- As discussed with maintainer, create folder for storing translations
It will give more control, everything will be stored in 1 repository
and it eliminates possible deletion or making translation private
@nifadyev
Copy link
Contributor Author

Hey @satwikkansal , sorry for a long delay, I had some motivation issues, but now I've finished translation and making some sanity check. It is not wise to read the whole document with ~4000 lines of code, so i will complete working on this PR in next few days and let you know
Meanwhile, I'd love to take part in next release, even in some minor role (e.x. checking examples, organize repo by labeling issues, closing irrelevant and moving some of them to discussions)

@satwikkansal
Copy link
Owner

Hey @nifadyev that's great news! I've been observing consistent commits from you over last few days, I hope you had fun working on the translation :)

And yes, feel free to let me know once you've finished the sanity check. I'll merge your branch!

I'll keep you in the loop about the next iteration, we can work together on that one.

cc @Elkiwa (also interested in working together on next release iteration)

@nifadyev
Copy link
Contributor Author

Good day @satwikkansal . I've finished minor refactoring and checking, and I believe the translation is ready to be merged.

I've also translated CONTRIBUTING and CONTRIBUTORS pages but not code-of-conduct . Should it be translated as well? It has official russian translation but for 2.0 version. But wtfpython has 1.4 version

@satwikkansal
Copy link
Owner

satwikkansal commented May 3, 2024

Good day @nifadyev

That's amazing, thanks!! I'll merge the PR. Regarding code-of-conduct, let's use version 2.0 and use the official translation. Could you make these changes as well in your PR?

@nifadyev
Copy link
Contributor Author

nifadyev commented May 3, 2024

Hey @satwikkansal , Code of Conduct translation is done

@satwikkansal
Copy link
Owner

Hi @nifadyev

This changes the primary translation in Contributors.md and other two files from English to Russia.

I'd suggest we create a directory named ru-russian inside the translations directory, where we can move these translated files, and we leave the original one in the root in English.

Could you please make that change?

@nifadyev
Copy link
Contributor Author

nifadyev commented May 4, 2024

Sure, it's done @satwikkansal . Some odds with git diff in code-of-conduct.md and CONTRIBUTING.md. I've downloaded files from repo and replaced them in PR but they still marked as changed in PR

@nifadyev
Copy link
Contributor Author

nifadyev commented May 4, 2024

Whew, that was a challenging task to fix the files and found minor issues in PR but I hope it is fine now

@satwikkansal
Copy link
Owner

Thanks for all your efforts @nifadyev, this looks great!!

Merging it now 🚀

@satwikkansal satwikkansal merged commit 77af92f into satwikkansal:master May 10, 2024
@nifadyev
Copy link
Contributor Author

Awesome, thank you, @satwikkansal . Looking forward to next tasks)

@nifadyev
Copy link
Contributor Author

One more minor fix - main README contains link to old translation. Should I make small PR or you can make it directly to master? The correct link is https://github.com/satwikkansal/wtfpython/tree/master/translations/ru-russian

@satwikkansal
Copy link
Owner

Yes please, let's do that! @nifadyev

@nifadyev
Copy link
Contributor Author

The PR is #334

satwikkansal added a commit that referenced this pull request May 13, 2024
Change link to Russian translation (follow up to PR #325)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add translation for Russian
2 participants