New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Russian translation #325
Conversation
- As discussed with maintainer, create folder for storing translations It will give more control, everything will be stored in 1 repository and it eliminates possible deletion or making translation private
Hey @satwikkansal , sorry for a long delay, I had some motivation issues, but now I've finished translation and making some sanity check. It is not wise to read the whole document with ~4000 lines of code, so i will complete working on this PR in next few days and let you know |
Hey @nifadyev that's great news! I've been observing consistent commits from you over last few days, I hope you had fun working on the translation :) And yes, feel free to let me know once you've finished the sanity check. I'll merge your branch! I'll keep you in the loop about the next iteration, we can work together on that one. cc @Elkiwa (also interested in working together on next release iteration) |
Good day @satwikkansal . I've finished minor refactoring and checking, and I believe the translation is ready to be merged. I've also translated |
Good day @nifadyev That's amazing, thanks!! I'll merge the PR. Regarding code-of-conduct, let's use version 2.0 and use the official translation. Could you make these changes as well in your PR? |
Hey @satwikkansal , Code of Conduct translation is done |
Hi @nifadyev This changes the primary translation in Contributors.md and other two files from English to Russia. I'd suggest we create a directory named Could you please make that change? |
Sure, it's done @satwikkansal . Some odds with |
Whew, that was a challenging task to fix the files and found minor issues in PR but I hope it is fine now |
Thanks for all your efforts @nifadyev, this looks great!! Merging it now 🚀 |
Awesome, thank you, @satwikkansal . Looking forward to next tasks) |
One more minor fix - main README contains link to old translation. Should I make small PR or you can make it directly to master? The correct link is |
Yes please, let's do that! @nifadyev |
The PR is #334 |
Change link to Russian translation (follow up to PR #325)
Translation is adaptive (not word-to-word) and it tries to save the original meaning.
As discussed with @satwikkansal, this translation (and possibly all existing ones) will be stored in folder inside original repository, not in fork. It will give more control because everything will be stored in 1 repository, and it eliminates possible deletion or making translation private.
Please feel free to review this PR. The PR will be periodically updated with new commits. 1 commit — 1 example
Resolves #297