Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checkout action on GHA CI and fix Lua 5.4 compat #110

Closed
wants to merge 6 commits into from

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Jan 2, 2025

The v2 might no longer work or soon stop working after GH updated to Node 20

Requires:

Summary by Sourcery

CI:

  • Update checkout action to v4.

Copy link

sourcery-ai bot commented Jan 2, 2025

Reviewer's Guide by Sourcery

This pull request updates the GitHub Actions workflow to use actions/checkout@v4 instead of actions/checkout@v2 because v2 might stop working after GitHub updated to Node 20.

File-Level Changes

Change Details Files
Update checkout action
  • Update actions/checkout from v2 to v4
.github/workflows/test.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Flamefire - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The PR title mentions updating a cache action, but the changes show an update to the checkout action instead. Please update the PR title to accurately reflect the changes being made.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Flamefire Flamefire changed the title Update cache action on GHA CI Update checkout action on GHA CI Jan 2, 2025
@Flamefire Flamefire force-pushed the patch-1 branch 3 times, most recently from c6bd6b8 to 6d3de0f Compare January 4, 2025 13:50
The couroutine result index is always 1, not dependent on the number of
results which is not available in < 5.4.
Errors during GC are shown as warnings in 5.4+
@Flamefire Flamefire changed the title Update checkout action on GHA CI Update checkout action on GHA CI and fix Lua 5.4 compat Jan 4, 2025
@Flamefire Flamefire closed this Jan 5, 2025
@Flamefire Flamefire deleted the patch-1 branch January 5, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant