-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update checkout action on GHA CI and fix Lua 5.4 compat #110
Conversation
Reviewer's Guide by SourceryThis pull request updates the GitHub Actions workflow to use File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Flamefire - I've reviewed your changes - here's some feedback:
Overall Comments:
- The PR title mentions updating a cache action, but the changes show an update to the checkout action instead. Please update the PR title to accurately reflect the changes being made.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
c6bd6b8
to
6d3de0f
Compare
The couroutine result index is always 1, not dependent on the number of results which is not available in < 5.4. Errors during GC are shown as warnings in 5.4+
The v2 might no longer work or soon stop working after GH updated to Node 20
Requires:
Summary by Sourcery
CI: