feat(whisper): add request parameter TimeStampGranularities and respo… #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #673 +/- ##
=======================================
Coverage 98.44% 98.45%
=======================================
Files 24 24
Lines 1353 1361 +8
=======================================
+ Hits 1332 1340 +8
Misses 15 15
Partials 6 6 ☔ View full report in Codecov by Sentry. |
sashabaranov
reviewed
Mar 5, 2024
audio_test.go
Outdated
| Temperature: 0.5, | ||
| Language: "en", | ||
| Format: AudioResponseFormatVerboseJSON, | ||
| TimeStampGranularities: []TimestampGranularity{TimestampGranularityWord}, |
There was a problem hiding this comment.
Thank you for the PR! Could we please keep this as a separate test?
There was a problem hiding this comment.
added a individual test TestAudioTimeGranularities
sashabaranov
reviewed
Mar 7, 2024
| TimeStampGranularities []TimestampGranularity | ||
| } | ||
|
|
||
| type Word struct { |
There was a problem hiding this comment.
nit: the name Word is very generic, could we please either change it to something like AudioResponseWord or make it anonymous similar to Segments []struct { in AudioResponse?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Add new struct field
timestamp_granularities[]andwordsfor whisper transcatiption APIProvide OpenAI documentation link
Describe your solution
Add OpenAI new added parameter in request&response
Tests
manual