Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issues with the paths used in the context of the local Saros instance #1098

Merged
merged 2 commits into from
Nov 10, 2020
Merged

Fixes issues with the paths used in the context of the local Saros instance #1098

merged 2 commits into from
Nov 10, 2020

Commits on Nov 9, 2020

  1. [FIX][E] #1093 Correctly display path of existing resource for error 

    Adjusts the error message displayed in cases where the user chooses the
option to create a new directory as part of the resource negotiation
using values pointing to an already existing directory. The message used
the 'toString()' of the IContainer object which included a resource type
designation at the start of the path. To avoid confusion, the
OS-specific path of the resource is used instead.

Resolves #1093.
    @tobous
    tobous committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    c0c5367 View commit details
    Browse the repository at this point in the history

  2. [INTERNAL][E] Use OS path when exclusively working in the local context 

    Replaces usages of IPath.toPortableString() with IPath.toOSString() in
cases where the logic is only working in the local context, i.e. when
displaying information to the user or setting values in a local dialog.

This was done to make it as easy as possible to recognize the path in
the local system. Making the path portable could be confusing for the
user as it no longer matches the representation in the local filesystem.
    @tobous
    tobous committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    474492c View commit details
    Browse the repository at this point in the history