Fixes issues with the paths used in the context of the local Saros instance #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusts the error message displayed in cases where the user chooses the option to create a new directory as part of the resource negotiation using values pointing to an already existing directory. The message used the 'toString()' of the IContainer object which included a resource type designation at the start of the path. To avoid confusion, the OS-specific path of the resource is used instead. Resolves #1093.
Replaces usages of IPath.toPortableString() with IPath.toOSString() in cases where the logic is only working in the local context, i.e. when displaying information to the user or setting values in a local dialog. This was done to make it as easy as possible to recognize the path in the local system. Making the path portable could be confusing for the user as it no longer matches the representation in the local filesystem.
tobous
added
Aspect: GUI
srossbach
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with the paths used in the context of the local Saros instance.
Commits
[FIX][E] #1093 Correctly display path of existing resource for error
Adjusts the error message displayed in cases where the user chooses the
option to create a new directory as part of the resource negotiation
using values pointing to an already existing directory. The message used
the
toString()of theIContainerobject which included a resource typedesignation at the start of the path. To avoid confusion, the
OS-specific path of the resource is used instead.
Resolves #1093.
[INTERNAL][E] Use OS path when exclusively working in the local context
Replaces usages of
IPath.toPortableString()withIPath.toOSString()incases where the logic is only working in the local context, i.e. when
displaying information to the user or setting values in a local dialog.
This was done to make it as easy as possible to recognize the path in
the local system. Making the path portable could be confusing for the
user as it no longer matches the representation in the local filesystem.