Implement referrer api #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperSandro2000
changed the title
SuperSandro2000
force-pushed
the
SubjectDigest
branch
8 times, most recently
from
7621548 to
4ade2f0
Compare
majewsky
reviewed
Feb 25, 2025
There was a problem hiding this comment.
I have looked at everything except for the internal/api part, and that stuff looks good. Can you please move the DB model changes and the stuff that fills these fields into a separate PR? i.e. everything not in internal/api. I would like to see these fields being filled first before we expose them in the API.
SuperSandro2000
force-pushed
the
SubjectDigest
branch
3 times, most recently
from
10f7336 to
1747bd1
Compare
SuperSandro2000
requested review from
VoigtS,
wagnerd3 and
Nuckal777
as code owners
SuperSandro2000
force-pushed
the
SubjectDigest
branch
3 times, most recently
from
ea2e960 to
1e54a81
Compare
majewsky
requested changes
Mar 23, 2025
This looks like a query that is going to be very costly if we have to sequence-scan the table.
SuperSandro2000
force-pushed
the
SubjectDigest
branch
from
951d2ba to
5252078
Compare
SuperSandro2000
force-pushed
the
SubjectDigest
branch
from
5252078 to
fe6bc01
Compare
majewsky
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.