Update to APIRule V2 and update packages dependencies. #23961
Conversation
|
|
|
hi @nataliasitko: would you want to go ahead and review this PR? The license/cla seems to have been compiled with, based on an email conversation with Arvun. I'm only waiting for the review to merge the PR. Thanks, |
| <!-- border --> | ||
|
|
||
|
|
||
| **3.** Enable Istio Sidecar Proxy Injection |
There was a problem hiding this comment.
You can enable sidecar injection during the namespace creation. Maybe it would be easier to include it in the previous step instead of editing the namespace when it's already created
There was a problem hiding this comment.
Fixed, move enable sidecar to Create Namespace step
...gure-approuter-multitenant-application/create-configure-approuter-multitenant-application.md
Outdated
Show resolved
Hide resolved
...gure-approuter-multitenant-application/create-configure-approuter-multitenant-application.md
Outdated
Show resolved
Hide resolved
...gure-approuter-multitenant-application/create-configure-approuter-multitenant-application.md
Outdated
Show resolved
Hide resolved
tutorials/deploy-multitenant-app-kyma/deploy-multitenant-app-kyma.md
Outdated
Show resolved
Hide resolved
|
|
||
|  | ||
| <!-- border --> | ||
|
|
||
| **2.** Access it in the browser, then the application will return the message that you defined before. |
There was a problem hiding this comment.
What message exactly should the application return based on the provided code snippets? Maybe we could also add this information to the tutorial.
I got Hello World, and I thought it was the expected result, but looking at the code snippet, I think I should also see the sub-domain and the zone ID, right?
There was a problem hiding this comment.
This tutorial doesn't bind the XSUAA, so cannot see the auth info. User see "Hello World!" is expected result. I will update it into content.
...s/implement-subscription-callback-multitenant/implement-subscription-callback-multitenant.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I think the last tutorial in the mission is the only point where the user can verify whether they have been following the steps correctly or not. I think it might also be helpful if we could add some hints in other tutorials. The only tutorial that comes to my mind, though, is Deploy a Multitenant Application to a Provider subaccount, Kyma Runtime
There, the user could check if the app is deployed correctly by verifying the resources' state, for example, in the Kyma dashboard (or using kubectl)
What do you think? It's just an idea, I don't have any strong opinion about this
There was a problem hiding this comment.
Exactly, good idea. I will add the check deployment state in the end of application deployment.
| @@ -21,7 +21,7 @@ primary_tag: software-product>sap-business-technology-platform | |||
| ### Create New Subaccount | |||
|
|
|||
|
|
|||
| Now, a consumer can subscribe to the application through the SAP BTP Account Cockpit. | |||
| Now, a consumer can subscribe to the application through SAP BTP cockpit. | |||
|
|
|||
| Create a new subaccount for the customer in the same Global Account with the multitenant application provider subaccount, for example, called `Customer`. | |||
|
|
|||
There was a problem hiding this comment.
In line 29, I would use the heading: Subscribe to Multitenant Application
There was a problem hiding this comment.
Sure, updated the heading already
tutorials/deploy-nodejs-application-kyma/deploy-nodejs-application-kyma.md
Outdated
Show resolved
Hide resolved
…reate-configure-approuter-multitenant-application.md Co-authored-by: Natalia Sitko <[email protected]>
…reate-configure-approuter-multitenant-application.md Co-authored-by: Natalia Sitko <[email protected]>
…reate-configure-approuter-multitenant-application.md Co-authored-by: Natalia Sitko <[email protected]>
…yma.md Co-authored-by: Natalia Sitko <[email protected]>
…t-subscription-callback-multitenant.md Co-authored-by: Natalia Sitko <[email protected]>
…tion-kyma.md Co-authored-by: Natalia Sitko <[email protected]>
|
Hi @rbrainey, Fixed all issue from my side. Could you please merge this PR? Thanks a lot! |
Changes notes: