fix(core): restore platform-aware keyboard shortcuts #6819
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Seems the facelift PR caused a regression that basically reverted this PR in terms of end result.
This PR reverts to using the
<Hotkeys>
component from the sanity core, which is platform aware.What to review
Ctrl + Option + P
on publish and similar, when on MacCtrl + Alt + P
on publish and similar, when not on Mac(This should be uncovered by the test suite, fwiw)
Testing
I added one test for this in the publish action. Ideally I would test all the different locations that use any kind of hotkeys that may involve the
Alt
key, but that would be a lot of tests in a lot of different places. I may introduce an ESLint rule to disallow the use of<Hotkeys>
from@sanity/ui
later.Notes for release