Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup dev:next-studio to use react v19 #6685

Merged
merged 1 commit into from
May 16, 2024
Merged

chore: setup dev:next-studio to use react v19 #6685

merged 1 commit into from
May 16, 2024

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented May 15, 2024

Description

The easiest way to test React v19 without making any changes to our packages, peer deps and more, is to update dev:next-studio to use the latest canary of next:
image

What to review

This only affects dev:next-studio, dev:turbo-studio and https://test-next-studio.sanity.build/test/structure deployments.

Testing

If the vercel deployment for test-next-studio is green on this PR we're good to go 🙌

Notes for release

N/A

@stipsan stipsan requested a review from a team as a code owner May 15, 2024 21:37
@stipsan stipsan requested review from cngonzalez and removed request for a team May 15, 2024 21:37
Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 9:42am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 9:42am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 9:42am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview May 16, 2024 9:42am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented May 15, 2024

Component Testing Report Updated May 16, 2024 9:48 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 38s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 7s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 31s 11 7 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 17s 20 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 3s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 7s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 20s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 29s 12 0 0

@ricokahler ricokahler requested review from a team as code owners May 15, 2024 21:56
@ricokahler ricokahler requested review from RitaDias and removed request for a team May 15, 2024 21:56
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/[email protected], npm/[email protected]

View full report↗︎

Copy link
Contributor

@RitaDias RitaDias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems low stakes so ✅
Carolina is out so if you want to get someone else from DX to give a green we should reach out but otherwise 👍

Merged via the queue into next with commit 61d1bc3 May 16, 2024
39 checks passed
@stipsan stipsan deleted the test-react-v19 branch May 16, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants