Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): replace hashlru with quicklru #6557

Merged
merged 1 commit into from May 3, 2024

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented May 3, 2024

Description

This replaces the very much abandoned hashlru dependency with qucklru which is actively maintained, includes some added features like supporting keys of any type, undefined as values, and also has proper TypeScript definitions.

Unfortunately, the recent couple of major versions of quicklru are ESM-only, so had to use the latest version that ships with CJS support, but still feels worth changing due to proper typescript definitions, and likely a straightforward future upgrade path.

What to review

The diff :)

Testing

We were using hashlru in two places - the inspect dialog and vision. I've manually tested that this change doesn't break anything.

Notes for release

n/a

Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview May 3, 2024 8:44am
test-next-studio ✅ Ready (Inspect) Visit Preview May 3, 2024 8:44am
test-studio ✅ Ready (Inspect) Visit Preview May 3, 2024 8:44am
1 Ignored Deployment
Name Status Preview Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) May 3, 2024 8:44am

Copy link
Contributor

github-actions bot commented May 3, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented May 3, 2024

Component Testing Report Updated May 3, 2024 9:24 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 39s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 20s 6 3 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 4s 14 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 6s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 20s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 15s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 22s 9 0 0

@bjoerge bjoerge marked this pull request as ready for review May 3, 2024 09:24
@bjoerge bjoerge requested a review from a team as a code owner May 3, 2024 09:24
@bjoerge bjoerge requested review from jtpetty and rexxars and removed request for a team May 3, 2024 09:24
@bjoerge bjoerge added this pull request to the merge queue May 3, 2024
Merged via the queue into next with commit d634727 May 3, 2024
40 checks passed
@bjoerge bjoerge deleted the chore/replace-hashlru-with-quicklru branch May 3, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants