Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schedule-publishing): update flag used to check scheduledPublishing #6543

Merged
merged 2 commits into from May 6, 2024

Conversation

pedrobonamin
Copy link
Contributor

@pedrobonamin pedrobonamin commented May 2, 2024

Description

The flag used to check the availability of scheduled publishing is incorrect, it should check scheduledPublishing, not sanityTasks

What to review

Testing

Notes for release

Fixes an issue in which users were incorrectly seeing the schedule publishing upsell ui.

Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview May 2, 2024 1:13pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 1:13pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 1:13pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) May 2, 2024 1:13pm

@pedrobonamin pedrobonamin marked this pull request as ready for review May 2, 2024 10:34
@pedrobonamin pedrobonamin requested a review from a team as a code owner May 2, 2024 10:34
@pedrobonamin pedrobonamin requested review from hermanwikner and removed request for a team May 2, 2024 10:34
Copy link
Contributor

github-actions bot commented May 2, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented May 2, 2024

Component Testing Report Updated May 2, 2024 1:18 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 41s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 20s 6 3 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 6s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 4s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 21s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 22s 9 0 0

Copy link
Member

@jordanl17 jordanl17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrobonamin pedrobonamin added this pull request to the merge queue May 6, 2024
Merged via the queue into next with commit 57fcbac May 6, 2024
39 checks passed
@pedrobonamin pedrobonamin deleted the schedule-publishing-feature-check branch May 6, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants