Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new disk commands #1545

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

jacdavi
Copy link
Contributor

@jacdavi jacdavi commented Oct 14, 2024

  • Adds commands for manipulating disks (wrappers for qemu-img)
    • disk <rebase,> <image> [backing file]
    • disk <set-backing,> <image> [backing file] (rebase with unsafe flag)
    • disk resize <image> <size>
    • disk commit <image>
  • Updates disk info with recursive option which prints entire backing chain
  • Updates disk info with new column for "in use"
    • This is tracked by checking if qemu has a lock on the disk file. This will mark backing images of booted images as in use
  • Change snapshot to use a backing file path relative to the base image rather than an absolute path
    • Change disk info output for backingfile to show relative path if backing file is relative
  • Minor code restructure for readability
  • Parse qemu-img info as json rather than regex on a plain string
  • Format disk size as human readable IEC format

@jacdavi jacdavi requested a review from aherna October 28, 2024 22:18
@jacdavi jacdavi self-assigned this Oct 28, 2024
@jacdavi jacdavi added this to the 2.10 milestone Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant