Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update actions checkout@v3 setup-node@v3 with node16 #94

Closed
wants to merge 24 commits into from

Conversation

heliomarpm
Copy link

Update

  • actions/checkout@v3
  • actions/setup-node@v3
    with: node-version: '>=16.8.0'

@gregorym
Copy link

bump

@marcofugaro
Copy link

@samuelmeuli could we merge this? otherwise this actions is dead

@teavver
Copy link

teavver commented Oct 14, 2023

@samuelmeuli

@megahirt
Copy link

Looks like this action is dead. We now need actions/checkout@v4 and actions/setup-node@v4 to get rid of node 16 warnings

@heliomarpm
Copy link
Author

Looks like this action is dead. We now need actions/checkout@v4 and actions/setup-node@v4 to get rid of node 16 warnings

I have made an updated version available
https://github.com/marketplace/actions/electron-builder-action-all-in-one

@megahirt
Copy link

megahirt commented May 2, 2024

Looks like this action is dead. We now need actions/checkout@v4 and actions/setup-node@v4 to get rid of node 16 warnings

I have made an updated version available https://github.com/marketplace/actions/electron-builder-action-all-in-one

@heliomarpm excellent! Thank you for maintaining a fork and fixing this up! I went to the fork but don't see an issue tracker (maybe that's intentional).

A request: could you name the tags with a 'v' e.g. 'v2.1'. Currently you have just '2.1' which means that this fork isn't a drop in replacement for the samuelmeuli action - the version format also needs to be changed

@heliomarpm
Copy link
Author

Parece que essa ação está morta. Agora precisamos de ações/checkout@v4 e ações/setup-node@v4 para nos livrarmos dos avisos do nó 16

Disponibilizei uma versão atualizada https://github.com/marketplace/actions/electron-builder-action-all-in-one

Excelente! Obrigado por manter um garfo e consertar isso! Eu fui para o fork, mas não vejo um rastreador de problemas (talvez isso seja intencional).

Um pedido: você poderia nomear as tags com um 'v', por exemplo, 'v2.1'. Atualmente você tem apenas '2.1', o que significa que este fork não é uma gota em substituição para a ação samuelmeuli - o formato da versão também precisa ser alterado

Ok @megahirt , I'll do it.
tks

@heliomarpm heliomarpm deleted the branch samuelmeuli:master May 26, 2024 19:05
@heliomarpm heliomarpm closed this May 26, 2024
@heliomarpm heliomarpm deleted the master branch May 26, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants