Remove mobile check for update_counts #1872
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check was added four years ago in .50e88b2bafd8b183b364484b57d3ed455db7b27a. The expectation was that the mobile clients would be migrated to using a combination of load_feeds and refresh_feeds. However, due to a typo, this check was only applied to Apple (iPad, iOS) clients. In the interim, we've ended up in the following situation: - The iOS client uses refresh_feeds, as it has for 12 years since 09affc6 - The Android client uses load_feeds with update_counts=True, as it has been allowed to get away with for years... Let's bring back equality for iOS clients!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check was added four years ago in .50e88b2bafd8b183b364484b57d3ed455db7b27a. The expectation was that the mobile clients would be migrated to using a combination of load_feeds and refresh_feeds. However, due to a typo, this check was only applied to Apple (iPad, iOS) clients. In the interim, we've ended up in the following situation:
Let's bring back equality for iOS clients!