Skip to content
This repository has been archived by the owner on Jul 21, 2021. It is now read-only.

Fix: Exists() should always return false when an error happenning and FLW parsing enhancement #246

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jasonjoo2010
Copy link

@jasonjoo2010 jasonjoo2010 commented Jun 4, 2020

This PR solved 2 small issues togethor:

  1. Newer zookeeper (tested with 3.6.x) outputs a little different in 4-letter-word response.
  2. Exists() acts different to ExistsW()

Description

FLW

Newer server will response different on latency element:

Latency min/avg/max: 0/0.9167/8

Which seems like some float numbers.

So I adjust the regex expression to pass it.

Exists()

Exists() will return true with an error except ErrNoNode:

error happened result error returned
nil true nil
ErrNoNode false nil
Any other true(incorrect) error

In addition ExistsW() acts correctly.

@coveralls
Copy link

coveralls commented Jun 4, 2020

Coverage Status

Coverage increased (+0.3%) to 79.896% when pulling 1f98c70 on jasonjoo2010:exists into 2cc03de on samuel:master.

@jasonjoo2010 jasonjoo2010 changed the title Fix: Exists() should always return false when an error happenning Fix: Exists() should always return false when an error happenning and FLW parsing enhancement Jun 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants