added a validation to check whether lock exists in case of network pa…

[continuum-Nikhil-Bhide]

This addresses #229

[continuum-Nikhil-Bhide]

IT seems that CI is failing on the make command.
FAIL github.com/samuel/go-zookeeper/zk 500.019s
Makefile:37: recipe for target 'test' failed
make: *** [test] Error 1
The command "make" exited with 2.

[coveralls]

Coverage decreased (-1.4%) to 78.222% when pulling 3853aff on continuum-Nikhil-Bhide:zk_229_lock_deadlock into 2cc03de on samuel:master.

[coveralls]

Coverage increased (+0.3%) to 79.886% when pulling 6288894 on continuum-Nikhil-Bhide:zk_229_lock_deadlock into 2cc03de on samuel:master.

[ydidukh]

This fix doesn't solve the problem you've described. CreateProtectedEphemeralSequential may return an empty path, while znode itself can be normally created by ZK server. To implement fix right, you need to match session identifiers for zknode objects and your connection if they are the same, and if so then you can assume that lock is acquired.

In addition to this you need to add tests for your new code and ensure that your code is properly formatted as it seems that it's not following golang styleguides.

[Metalscreame]

As @ydidukh this might work. Have you tried to test it manually?

Suggestion. Is there a possibility to listen for the State of the client? if yes, there might be a way to make new connection when the state is back to connected and assign session identifiers existing locks (or recreate them with new identifiers).

[continuum-Nikhil-Bhide]

Hi Samuel,
Requesting you to verify this change and approve the merge.

• Nikhil