Skip to content
This repository has been archived by the owner on Jul 21, 2021. It is now read-only.

Fix randomness of servers shuffling #146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix randomness of servers shuffling #146

wants to merge 1 commit into from

Conversation

tevino
Copy link

@tevino tevino commented Nov 2, 2016

No description provided.

@tevino
Copy link
Author

tevino commented Nov 2, 2016

@samuel please review.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 81.31% when pulling a260e37 on tevino:patch-1 into 1d7be4e on samuel:master.

@tevino tevino closed this Nov 2, 2016
@tevino tevino reopened this Nov 2, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 81.182% when pulling a260e37 on tevino:patch-1 into 1d7be4e on samuel:master.

@tevino
Copy link
Author

tevino commented Dec 13, 2016

The seed of global Rand object is not determined, the value set here could be overrode by anyone.

IMHO: Libraries should not rely on or even modify the global seed.

@samuel samuel force-pushed the master branch 2 times, most recently from e51ba65 to 471cd4e Compare November 17, 2017 19:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamdecaf adamdecaf adamdecaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tevino @coveralls @adamdecaf