Wextra #125
Merged
Wextra #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jkbonfield
commented
Aug 19, 2024
jkbonfield
commented
- Some fall-through comment annotations, but no actual code change
- Also updated NEWs with changes to-date so we have less to do once we're ready for a release.
The main things these picked up are fall-throughs on switch statements, all of which were deliberate. However they're now annotated as such so no longer complain. In samtools this did detect a genuine bug so it's worth adding (and annotating to silence FPs)
Not strictly part of the same change, but it's all necessary prior to the next release and neither commit is a change of code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.