Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced lists plugin implementation #690

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

abetis
Copy link
Contributor

@abetis abetis commented Apr 12, 2018

The plugin implement:

  • Drop-down menus to select bullets and numbered lists types
  • Allow configuring the options shown in the drop down lists based on the standard:
    https://developer.mozilla.org/en-US/docs/Web/CSS/list-style-type
  • Both lists types use the HTML5 styling version, although OL can still use the type attribute, the styling version allows more options (I personally need the additional numbering option that will be used with custom configuration

This was referenced Apr 12, 2018
@brunoais
Copy link
Collaborator

brunoais commented Apr 12, 2018

Please do not link to w3schools. Those guys are too money hungry compared to the actual help they provide. w3s don't care about standards until it hurts their income. They also don't participate in the standards definitions and don't care to link to the official documentation at w3's website.
Link to MDN or w3c instead.

@brunoais brunoais changed the title Enjanced lists plugin implementation Enhanced lists plugin implementation Apr 12, 2018
@abetis
Copy link
Contributor Author

abetis commented Apr 12, 2018

I don't care. Both provide free information on the web. w3 looks more simple to understand.

@brunoais
Copy link
Collaborator

Because you don't care, I updated for you.

@brunoais brunoais requested a review from samclarke April 12, 2018 12:10
* new lines in their own list item.
* See issue #359
*/
function fixFirefoxListBug(editor) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What prevents you from making an algorithm that works on all browsers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I follow the original list commands implementation:

	// START_COMMAND: Bullet List
	bulletlist: {
		exec: function () {
			fixFirefoxListBug(this);
			this.execCommand('insertunorderedlist');
		},
		tooltip: 'Bullet list'
	},
	// END_COMMAND
	// START_COMMAND: Ordered List
	orderedlist: {
		exec: function () {
			fixFirefoxListBug(this);
			this.execCommand('insertorderedlist');
		},
		tooltip: 'Numbered list'
	},
	// END_COMMAND

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough

@abetis
Copy link
Contributor Author

abetis commented Apr 13, 2018

Added alternative lists logic from #592
Can be configured to use the OL and UL lists format if someone need it.

@samclarke samclarke added this to the v4.0.0 milestone Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants