feat(code): allow any code type #94
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change Code(...) to accept any and Code() to return any. Update docs/tests for int and string codes. Fix stacktrace path normalization in module mode. BREAKING CHANGE: OopsError.Code() now returns any (was string).
samber
reviewed
Dec 29, 2025
Owner
samber
left a comment
samber
left a comment
There was a problem hiding this comment.
Thanks for the contrib.
Just 1 comment
| return e.code | ||
| }, | ||
| ) | ||
| func (o OopsError) Code() any { |
Owner
There was a problem hiding this comment.
Why not use the recursive getDeepestErrorAttribute function ?
Author
There was a problem hiding this comment.
Good point.
I initially avoided getDeepestErrorAttribute because it’s constrained to T comparable, and any isn’t comparable in general (e.g. map/slice). Also its coalescing logic assumes “zero value = empty”, which would incorrectly treat 0 as empty for int codes.
So I implemented a small custom recursion with an explicit emptiness rule: only nil and "" are considered “unset”, everything else (including 0) is a valid code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #33 by allowing oops.Code(...) to accept multiple code types (e.g. int and string) instead of only string.
Changes:
Note (Breaking Change):
value.