Skip to content

chore(ci): adding codeql#98

Merged
samber merged 1 commit intomasterfrom
chore/adding-codeql
Feb 25, 2026
Merged

chore(ci): adding codeql#98
samber merged 1 commit intomasterfrom
chore/adding-codeql

Conversation

@samber
Copy link
Owner

@samber samber commented Feb 25, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 25, 2026 18:14
@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.47%. Comparing base (596dafd) to head (593a629).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   87.47%   87.47%           
=======================================
  Files          28       28           
  Lines        1980     1980           
=======================================
  Hits         1732     1732           
  Misses        227      227           
  Partials       21       21           
Flag Coverage Δ
unittests 87.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CI workflows to run on pull_request and adds CodeQL code scanning into the existing lint workflow.

Changes:

  • Enable pull_request triggers (and restrict push triggers to master) for test and lint workflows.
  • Add a weekly scheduled run for the lint workflow.
  • Add CodeQL init/autobuild/analyze steps to the lint workflow.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/test.yml Adds pull_request trigger and restricts push runs to the master branch.
.github/workflows/lint.yml Adds schedule + CodeQL scanning steps and introduces explicit job permissions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

strategy:
fail-fast: false
permissions:
# required for codeql analysis
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The job-level permissions block sets only security-events: write. In GitHub Actions, specifying any job permissions usually sets all unspecified permissions to none, which can break actions/checkout (needs at least contents: read) and CodeQL initialization. Add explicit contents: read (and any other required scopes such as actions: read if needed) alongside security-events: write.

Suggested change
# required for codeql analysis
# required for codeql analysis
contents: read

Copilot uses AI. Check for mistakes.
Comment on lines +35 to +41
- name: Initialize CodeQL
uses: github/codeql-action/init@v4
with:
languages: go
- name: Autobuild
uses: github/codeql-action/autobuild@v4
- name: Perform CodeQL Analysis
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the CodeQL steps are placed after other steps in this job, any failure earlier (e.g., linting or Bearer) will prevent CodeQL from running and uploading results. If you want CodeQL results even when other checks fail, run CodeQL in a separate job (recommended) or ensure the CodeQL steps run with appropriate if: always() / continue-on-error handling on earlier steps.

Suggested change
- name: Initialize CodeQL
uses: github/codeql-action/init@v4
with:
languages: go
- name: Autobuild
uses: github/codeql-action/autobuild@v4
- name: Perform CodeQL Analysis
- name: Initialize CodeQL
if: always()
uses: github/codeql-action/init@v4
with:
languages: go
- name: Autobuild
if: always()
uses: github/codeql-action/autobuild@v4
- name: Perform CodeQL Analysis
if: always()

Copilot uses AI. Check for mistakes.
@samber samber merged commit 1e07f43 into master Feb 25, 2026
17 checks passed
@samber samber deleted the chore/adding-codeql branch February 25, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants