feat: Add time constants for Day, Week, Month, and Year#609
Closed
liorkesten wants to merge 2 commits intosamber:masterfrom
Closed
feat: Add time constants for Day, Week, Month, and Year#609liorkesten wants to merge 2 commits intosamber:masterfrom
liorkesten wants to merge 2 commits intosamber:masterfrom
Conversation
Owner
|
hey @liorkesten There is a good reason if go does not bring those constants already. 1 day is not always 24 hours The stdlib comes with Feel free to argue until I close the PR. |
Contributor
|
There's a pretty cool list of common falsehoods about time: https://gist.github.com/timvisee/fcda9bbdff88d45cc9061606b4b923ca |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Added time constants for Day, Week, Month, and Year to ensure consistency and simplify access, avoiding inline calculations like 24 * time.Hour.