testhelper/smbclient.py: use smbprotocol python module #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spuiuk
force-pushed
the
smbprotocol
branch
7 times, most recently
from
1c792b7 to
c9012f1
Compare
spuiuk
force-pushed
the
smbprotocol
branch
2 times, most recently
from
7e52991 to
b8d9e95
Compare
synarete
reviewed
Jun 27, 2024
spuiuk
force-pushed
the
smbprotocol
branch
2 times, most recently
from
3b4217b to
38c286e
Compare
synarete
approved these changes
Jun 27, 2024
anoopcs9
requested changes
Jun 28, 2024
pysmb only support SMB2.0 version. The samba-container defaults to using SMB2.1 protocol and we are unable to use pysmb to connect to the samba server. This is a major issue. The smbprotocol python module avoids this problem. Signed-off-by: Sachin Prabhu <[email protected]>
The smbclient high level calls make use of a global configuration which ends up reusing the client guid. This doesn't work for us in our multi client testing. Make use of some low level calls at the point of setting up the connection so that we use different client guids for each connection. This particular workaround requires setting the connection cache bypassing the methods available in the smbclient module. Setting this as a separate commit to highlight the part which may break if the underlying implementation is changed in the future. Signed-off-by: Sachin Prabhu <[email protected]>
Shwetha-Acharya
approved these changes
Jun 28, 2024
anoopcs9
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pysmb only support SMB2.0 version. The samba-container defaults to using SMB2.1 protocol and we are unable to use pysmb to connect to the samba server. This is a major issue.
The smbprotocol python module avoids this problem.