-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate inventory and ssh config dynamically #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhernandez
force-pushed
the
ssh-config
branch
5 times, most recently
from
February 28, 2024 18:59
c578b73
to
1a61584
Compare
Merged
🎉 All dependencies have been resolved ! |
Signed-off-by: Xavi Hernandez <[email protected]>
Signed-off-by: Xavi Hernandez <[email protected]>
The dynamically created inventory is stored on a file to be used in other independent playbooks. Signed-off-by: Xavi Hernandez <[email protected]>
Accesses to 'config.nodes[inventory_hostname]' can now be simplified to just 'site'. Signed-off-by: Xavi Hernandez <[email protected]>
xhernandez
force-pushed
the
ssh-config
branch
from
February 29, 2024 15:49
1a61584
to
c292fcc
Compare
anoopcs9
requested changes
Mar 5, 2024
Signed-off-by: Xavi Hernandez <[email protected]>
Signed-off-by: Xavi Hernandez <[email protected]>
Signed-off-by: Xavi Hernandez <[email protected]>
anoopcs9
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the reorganizing work, really appreciated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reduces the tasks done by the provisioners to the minimum, moving most of the tasks to other common places. It also builds the inventory in a dynamic way to provide flexibility for the provisioners.
The SSH configuration is also built dynamically and it uses a new key to allow password-less root SSH between all nodes, making it independent of vagrant.
Depends on #86.