Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: do not use pip to install python modules #84

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

spuiuk
Copy link
Collaborator

@spuiuk spuiuk commented Feb 12, 2024

Since we have moved to using tox to run tests on the client, we can install the required dependencies from within tox. We do not need to use pip to install the modules on the clients.

Since we have moved to using tox to run tests on the client, we can
install the required dependencies from within tox. We do not need to use
pip to install the modules on the clients.

Signed-off-by: Sachin Prabhu <[email protected]>
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks OK to me.

@anoopcs9 anoopcs9 merged commit d8fd8c1 into samba-in-kubernetes:main Feb 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants