smb_share.conf.j2: Add ignore system acls option to vfs_acl_xattr
#82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoopcs9
force-pushed
the
add-ignore-system-acls
branch
2 times, most recently
from
c74ef1a to
a5b4518
Compare
xhernandez
reviewed
Feb 5, 2024
anoopcs9
force-pushed
the
add-ignore-system-acls
branch
from
a5b4518 to
6e41b20
Compare
xhernandez
reviewed
Feb 8, 2024
anoopcs9
force-pushed
the
add-ignore-system-acls
branch
from
6e41b20 to
7d7d700
Compare
Expanding the backend specific cluster settings we now introduce a new key called "options" for already existing "samba_shares" where one could define additonal smb.conf share options to be configured with share definition. Signed-off-by: Anoop C S <[email protected]>
For better coverage of smbtorture tests we require 'ignore system acls' enabled for acl_xattr VFS module. This is done to successfully complete those tests where such a lossy translation attempt from NT ACLs to POSIX ACLs would result in failures by design. Signed-off-by: Anoop C S <[email protected]>
anoopcs9
force-pushed
the
add-ignore-system-acls
branch
from
7d7d700 to
424d7c1
Compare
xhernandez
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For better coverage of smbtorture tests we require
ignore system aclsenabled for acl_xattr VFS module. This is done to successfully complete those tests where such a lossy translation attempt from NT ACLs to POSIX ACLs would result in failures by design.fixes #81