Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for personal and local settings #78

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

xhernandez
Copy link
Collaborator

With this patch it will be possible to define customized settings using user defined files outside of the repository that will override the values from settings.yml.

This can be useful to adapt sit-environment to the personal environment characteristics without having to modify the settings.yml file each time it's updated.

There are two places were personal settings can be defined:

  • ~/.site/settings.yml
    This file can contain settings used by all sit-environments. This one overrides configurations from settings.yml.

  • ./local.yml (normally the root of the repo)
    This file can contain settings specific for this instance of the repo. This one overrides configurations from settings.yml and ~/.site/settings.yml.

@xhernandez xhernandez marked this pull request as ready for review January 18, 2024 12:55
With this patch it will be possible to define customized settings using
user defined files outside of the repository that will override the
values from settings.yml.

This can be useful to adapt sit-environment to the personal environment
characteristics without having to modify the settings.yml file each time
it's updated.

There are two places were personal settings can be defined:

  - ~/.site/settings.yml
    This file can contain settings used by all sit-environments. This
    one overrides configurations from settings.yml.

  - ./local.yml (normally the root of the repo)
    This file can contain settings specific for this instance of the
    repo. This one overrides configurations from settings.yml and
    ~/.site/settings.yml.

Signed-off-by: Xavi Hernandez <[email protected]>
Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

@anoopcs9 anoopcs9 merged commit fb4c851 into samba-in-kubernetes:main Feb 2, 2024
6 checks passed
@xhernandez xhernandez deleted the local-settings branch February 2, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants