Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make backend filesystems available from client machines #77

Merged
merged 5 commits into from
Feb 13, 2024

Conversation

xhernandez
Copy link
Collaborator

This PR makes it possible to directly access the backend filesystem from the client machines bypassing Samba layer.

This is exclusively created for testing purposes since bypassing Samba will most probably cause problems (multiprotocol access is not supported yet), but it will simplify the implementation of some tests.

The backend filesystems are mounted inside /mnt/backends/, in a subdirectory with the same name as the samba share.

This is currently implemented using SSHFS, which doesn't support extended attributes, so there may be limitations on what can be done directly on the backend. If needed, this can be improved in the future by using an NFSv4 mount instead of SSHFS.

@xhernandez xhernandez force-pushed the sshfs branch 3 times, most recently from 0a51d8e to c442e00 Compare January 17, 2024 11:54
@xhernandez xhernandez marked this pull request as ready for review January 17, 2024 14:42
@xhernandez xhernandez force-pushed the sshfs branch 2 times, most recently from 96cfbb2 to 0198f17 Compare February 2, 2024 12:03
spuiuk
spuiuk previously approved these changes Feb 12, 2024
Copy link
Collaborator

@spuiuk spuiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - Looks promising. Will open more options for the testing environment.

Once these changes have been committed, we make changes to the way the exports are listed in test-info.yml for the client machines to consume.

Previously, for VFS shares, the backend filesystem was not always mounted.
Now it's always present inside /mnt.

Signed-off-by: Xavi Hernandez <[email protected]>
Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Copy link
Collaborator

@spuiuk spuiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - the second time (after I just commented and forgot to actually github ack it!)

@anoopcs9 anoopcs9 merged commit f984446 into samba-in-kubernetes:main Feb 13, 2024
6 checks passed
@xhernandez xhernandez deleted the sshfs branch February 14, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants