Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASAP hot-fix - current master does not work #11

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

mi4uu
Copy link
Contributor

@mi4uu mi4uu commented Nov 17, 2023

generated projects wasn't working.
please merge ASAP since current version in master does not produce any working results.

for web

  • FIX: create assets folder - project was failing to generate project since there was no proper folder to write assets to
  • FIX: make use of static_routers - it was not present in results - project failed to compile

for api

  • FIX: remove routers_static usage in routers - module not exists, generated project does not compile

…in api anyway and it breaks generated project
FIX: use and generate routers_static - file was missing in generated project
@mi4uu mi4uu changed the title Mi4uu fix make it work ASAP hot-fix - currnt master does not work Nov 17, 2023
@mi4uu mi4uu changed the title ASAP hot-fix - currnt master does not work ASAP hot-fix - current master does not work Nov 17, 2023
@fankaiLiu fankaiLiu merged commit 0f426ff into salvo-rs:main Nov 17, 2023
@fankaiLiu
Copy link
Collaborator

generated projects wasn't working. please merge ASAP since current version in master does not produce any working results.

for web

  • FIX: create assets folder - project was failing to generate project since there was no proper folder to write assets to
  • FIX: make use of static_routers - it was not present in results - project failed to compile

for api

  • FIX: remove routers_static usage in routers - module not exists, generated project does not compile

Wow, you're a lifesaver! we can't thank you enough for that.
I used to manually test the project and then change the code without covering all the options and scribble and submit the code.I've gone ahead and added a test to our project. Hopefully the bugs can be minimized, thanks again for your contribution and have a great day! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants