-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Fix for module.run show result as True when module returned False as result #67924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@twangboy I found another flaw in the current change I made. When the result is set to a non- |
I have fixed it, I won't change anything for now unless a maintainer or CI does not agree with current change. Personally I think as a bonus the change is now more readable. |
I also already made a PR for the same issue a while ago which is waiting for merging. Maybe you could have a look at it: #67115 |
Just need to migrate that test to pytest on #67115 |
Close as #67115 seems to be a better fix and code cleanup. |
What does this PR do?
What issues does this PR fix or reference?
Fixes #65842
Previous Behavior
If
module.run
was running a module which returnedFalse
in it'sresult
, themodule.run
state would return it as successful with it'sresult
set toTrue
.New Behavior
With this change the state will have
result
set toFalse
if the module contains aresult
where the value not is equal toTrue
.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes