-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes 67185: Makes the correct pki_dir available for key_cache #67913
base: 3007.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix tests
I don't think there is something to fix here. The tests seems to be totally unrelated to the change made in this PR. They are the same failed tests of another PR to the 3007.x branch (#67884), some looks to be related to TestsHttpClient timeouts and the others with the wrong minion list, with four unexpected minions in the Assert. Probably because the "async" behaviour, these |
@piterpunk The nightly build for the 3007.x branch is currently green, see https://github.com/saltstack/salt/actions/runs/14072468234, and the PR #67884, I just rebased it for the latest on the 3007.x branch and it is rerunning. Hit rerun on the jobs to see if that helps, seen issues with ARM64 containers. |
Even in the nightly build the https://github.com/saltstack/salt/actions/runs/14072468234/job/39414670793#step:36:9424 It succeeds in a subsequent try, but it seems to work by cheer insistence. |
What does this PR do?
Makes the correct PKI directory available for handle_key_cache function.
What issues does this PR fix or reference?
Fixes #67185
Previous Behavior
New Behavior
No error
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No